Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/event trigger UI refinements #10085

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ullasgowda
Copy link
Contributor

Description

This PR provides fix for issue #10080
Fix minor UI related issues in Event Triggers - Header Section.

Changelog

Component : console

Type: bugfix

Product: community-edition

Short Changelog

  • increase the width for header-edit section, to properly allow the inputs to occupy the avilable width
  • add medium level z-index over header value-type dropdown options, so it renders over the othere input attributes.
  • use similar padding for table-row-data with respect to the table-row-header for table which shows existing headers for event triggers

Long Changelog

Related Issues

Solution and Design

  • Increase width for header editor and input attribute
    before:
    image

after:
image

  • Add same padding to table-data with respect to table-header
    before:
    image

after:
image

  • z-index for dropdown options
    before:
    image

after:
image

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • [] Yes
    • [] Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • [] Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • [] Yes
      • [] Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • [] Yes
      • [] Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • [] Yes
      • [] Not required

GraphQL

  • No new GraphQL schema is generated
  • [] New GraphQL schema is being generated:
    • [] New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • [] There are breaking changes:

    1. Metadata API

      Existing query types:

      • [] Modify args payload which is not backward compatible
      • [] Behavioural change of the API
      • [] Change in response JSON schema
      • [] Change in error code
    2. GraphQL API

      Schema Generation:

      • [] Change in any NamedType
      • [] Change in table field names

      Schema Resolve:-

      • [] Change in treatment of null value for any input fields
    3. Logging

      • [] Log JSON schema has changed
      • [] Log type names have changed

@ullasgowda ullasgowda requested a review from a team as a code owner January 4, 2024 17:59
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @ullasgowda, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

… of 12 col, increase input witdh for header key-value attributes
@ullasgowda ullasgowda force-pushed the fix/event-trigger-ui-refinements branch from bc7e38e to 9f1bed3 Compare January 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants